emkornfield commented on pull request #8190: URL: https://github.com/apache/arrow/pull/8190#issuecomment-693191522
Overall, this looks like a good first pass, that I think will unblock integration testing (I'll try to make add a proof of concepts C++ round trip integration test on Decimal256 branch this week). I think there might potentially be some places where traits could be used to removed duplicate code via enable if, but I don't think that should block this check in. I'm going to merge to Decimal256 branch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
