jhorstmann opened a new issue, #2071:
URL: https://github.com/apache/arrow-rs/issues/2071

   **Which part is this question about**
   
   I noticed that a lot of the `append` or `append_null` methods in builders 
are always returning `Ok(())`. There are only very few builders that can 
legitimately return an error, for example dictionaries on overflow or some 
validation for decimals.
   
   **Describe your question**
   
   I'm wondering whether this is a design decision, to make all builder apis 
seem more consistent or if it is maybe a leftover from a time when we had 
fallible allocation logic.
   
   **Additional context**
   
   Although the compiler should be able to optimize these away, there could 
still be a performance impact in some cases. It also makes it more difficult to 
use these builders in an infallible context.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to