[GitHub] [arrow] rok commented on a diff in pull request #13594: ARROW-17065: [Python] Allow using subclassed ExtensionScalar in ExtensionType

Fri, 15 Jul 2022 02:41:18 -0700 


rok commented on code in PR #13594:
URL: https://github.com/apache/arrow/pull/13594#discussion_r921998531


##########
python/pyarrow/scalar.pxi:
##########
@@ -902,10 +902,7 @@ cdef class ExtensionScalar(Scalar):
         """
         Return this scalar as a Python object.
         """
-        if self.value is None:
-            return None
-        else:
-            return self.type.scalar_as_py(self.value)
+        return self.value if self.value is not None else None

Review Comment:
   Oh. Yeah, that is suspicious 😬 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to