alamb opened a new pull request, #2917: URL: https://github.com/apache/arrow-datafusion/pull/2917
# Which issue does this PR close? Fixes https://github.com/apache/arrow-datafusion/issues/2916 Fixes https://github.com/apache/arrow-datafusion/issues/2719 # Rationale for this change Some people have been seeing the `verify_release_candidate.sh` script fail when verifying arrow releases. The failures are due to paths into the "testing data" which are not properly normalized # What changes are included in this PR? Note here is an example of the contents that are in the tarball (note the presence of `testing` and `parquet-testing`): ```shell ls /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-10.0.0.XXXXX.s39Dslgg/apache-arrow-datafusion-10.0.0 CHANGELOG.md README.md dev/ rustfmt.toml CODE_OF_CONDUCT.md benchmarks/ docs/ target/ CONTRIBUTING.md ci/ header test-rustup/ Cargo.lock conbench/ integration-tests/ testing/ Cargo.toml datafusion/ parquet-testing/ LICENSE.txt datafusion-cli/ pre-commit.sh* NOTICE.txt datafusion-examples/ python/ ``` # Are there any user-facing changes? Hopefully the verify script works on subsequent releases # Testing Note that I don't ```shell (arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ env | grep ARROW_TEST_DATA (arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ env | grep PARQUET_TEST_DATA ``` Prior to this change, running: ```shell ./dev/release/verify-release-candidate.sh 10.0.0 1 ``` Would fail for me locally (with the same diff reported by @nevi-me in https://github.com/apache/arrow-datafusion/issues/2916) afterwards it passes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
