nealrichardson commented on code in PR #13621: URL: https://github.com/apache/arrow/pull/13621#discussion_r922187503
########## r/R/dplyr-group-by.R: ########## @@ -58,13 +58,13 @@ group_by.arrow_dplyr_query <- function(.data, group_by.Dataset <- group_by.ArrowTabular <- group_by.RecordBatchReader <- group_by.arrow_dplyr_query groups.arrow_dplyr_query <- function(x) syms(dplyr::group_vars(x)) -groups.Dataset <- groups.ArrowTabular <- groups.RecordBatchReader <- function(x) NULL +groups.Dataset <- groups.ArrowTabular <- groups.RecordBatchReader <- function(x) syms(dplyr::group_vars(x)) Review Comment: Right, sorry, I forgot about that case. Then let's do this, which is a pattern we use throughout ```suggestion groups.Dataset <- groups.ArrowTabular <- groups.RecordBatchReader <- groups.arrow_dplyr_query ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
