eitsupi commented on code in PR #13621:
URL: https://github.com/apache/arrow/pull/13621#discussion_r922190605
##########
r/tests/testthat/test-metadata.R:
##########
@@ -383,6 +383,7 @@ test_that("grouped_df metadata is recorded (efficiently)", {
grouped_tab <- Table$create(grouped)
expect_r6_class(grouped_tab, "Table")
expect_equal(grouped_tab$r_metadata$attributes$.group_vars, "a")
+ expect_equal(grouped_tab$metadata$r$attributes$.group_vars, "a")
Review Comment:
I interpreted this test being left in place despite the change in metadata
structure (`r_metadata` to `metadata$r`) as being for compatibility, but is it
safe to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
