tustvold commented on PR #2038:
URL: https://github.com/apache/arrow-rs/pull/2038#issuecomment-1186002441
Unfortunately this still represents a non-trivial performance regression for
strings...
```
array_string_from_vec 128
time: [3.0274 us 3.0277 us 3.0279 us]
change: [+49.381% +49.449% +49.526%] (p = 0.00 <
0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) low mild
7 (7.00%) high mild
4 (4.00%) high severe
array_string_from_vec 256
time: [4.2068 us 4.2092 us 4.2123 us]
change: [+37.016% +37.296% +37.749%] (p = 0.00 <
0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe
array_string_from_vec 512
time: [6.6659 us 6.6680 us 6.6700 us]
change: [+34.300% +34.358% +34.416%] (p = 0.00 <
0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
struct_array_from_vec 128
time: [4.2799 us 4.2823 us 4.2844 us]
change: [+38.535% +38.605% +38.688%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
struct_array_from_vec 256
time: [6.2571 us 6.2585 us 6.2599 us]
change: [+40.854% +40.924% +40.986%] (p = 0.00 <
0.05)
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
1 (1.00%) high mild
1 (1.00%) high severe
struct_array_from_vec 512
time: [9.6797 us 9.6819 us 9.6845 us]
change: [+35.304% +35.364% +35.419%] (p = 0.00 <
0.05)
Performance has regressed.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe
struct_array_from_vec 1024
time: [16.488 us 16.493 us 16.500 us]
change: [+33.968% +34.039% +34.116%] (p = 0.00 <
0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe
```
I wonder if you might like to try using something like
[hotspot](https://github.com/KDAB/hotspot) or
[cargo-flamegraph](https://github.com/flamegraph-rs/flamegraph) to see where
the additional slowdown is coming from? I can try to take a look, but I'm a
little bit swamped at the moment so not sure when I'll have time to investigate
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
