alamb commented on code in PR #2918:
URL: https://github.com/apache/arrow-datafusion/pull/2918#discussion_r922667294


##########
ci/scripts/rust_clippy.sh:
##########
@@ -18,4 +18,4 @@
 # under the License.
 
 set -ex
-cargo clippy --all-targets --workspace -- -D warnings
+cargo clippy --all-targets --workspace --features avro,jit,pyarrow,scheduler 
-- -D warnings

Review Comment:
   I tried running with 
   
   ```suggestion
   cargo clippy --all-targets --workspace --all-features -- -D warnings
   ```
   
   
   ```
   error[E0554]: `#![feature]` may not be used on the stable release channel
      --> 
/Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/packed_simd_2-0.3.8/src/lib.rs:214:1
       |
   214 | / #![feature(
   215 | |     adt_const_params,
   216 | |     repr_simd,
   217 | |     rustc_attrs,
   ...   |
   224 | |     custom_inner_attributes,
   225 | | )]
       | |__^
   ```



##########
ci/scripts/rust_clippy.sh:
##########
@@ -18,4 +18,4 @@
 # under the License.
 
 set -ex
-cargo clippy --all-targets --workspace -- -D warnings
+cargo clippy --all-targets --workspace --features avro,jit,pyarrow,scheduler 
-- -D warnings

Review Comment:
   I tried running with 
   
   ```suggestion
   cargo clippy --all-targets --workspace --all-features -- -D warnings
   ```
   
   and sadly it failed
   
   ```
   error[E0554]: `#![feature]` may not be used on the stable release channel
      --> 
/Users/alamb/.cargo/registry/src/github.com-1ecc6299db9ec823/packed_simd_2-0.3.8/src/lib.rs:214:1
       |
   214 | / #![feature(
   215 | |     adt_const_params,
   216 | |     repr_simd,
   217 | |     rustc_attrs,
   ...   |
   224 | |     custom_inner_attributes,
   225 | | )]
       | |__^
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to