jhorstmann commented on code in PR #2056:
URL: https://github.com/apache/arrow-rs/pull/2056#discussion_r922877828
##########
arrow/src/array/array_boolean.rs:
##########
@@ -242,14 +242,19 @@ impl<Ptr: Borrow<Option<bool>>> FromIterator<Ptr> for
BooleanArray {
}
});
+ let null_buf: Buffer = null_builder.into();
Review Comment:
That's an interesting idea and it passes all the existing test cases. It
also changes behavior when someone passes an explicit null buffer, but I can't
think of a reason why people would rely on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
