AlenkaF commented on code in PR #13311: URL: https://github.com/apache/arrow/pull/13311#discussion_r922965062
########## python/pyarrow/src_arrow/CMakeLists.txt: ########## @@ -0,0 +1,447 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# +# arrow_python +# + +cmake_minimum_required(VERSION 3.5) + +# RPATH settings on macOS do not affect install_name. +# https://cmake.org/cmake/help/latest/policy/CMP0068.html +if(POLICY CMP0068) + cmake_policy(SET CMP0068 NEW) +endif() + +# +# Define +# ARROW_SOURCE_DIR: location of arrow/cpp +# CMAKE_MODULE_PATH: location of cmake_modules in python +# + +get_filename_component(PYARROW_SOURCE_DIR ${CMAKE_SOURCE_DIR} DIRECTORY) +get_filename_component(PYTHON_SOURCE_DIR ${PYARROW_SOURCE_DIR} DIRECTORY) +get_filename_component(ARROW_SOURCE ${PYTHON_SOURCE_DIR} DIRECTORY) +set(ARROW_CPP_SOURCE_DIR "${ARROW_SOURCE}/cpp") +set(ARROW_SOURCE_DIR "${ARROW_CPP_SOURCE_DIR}") Review Comment: I thought it was for `add_arrow_lib` but looking at it now it seems it is only used in case of a sdist build https://github.com/apache/arrow/blob/385fe4315b2ccefc90860cee18a3661f67b57c3e/python/pyarrow/src_arrow/CMakeLists.txt#L199-L203 and so can be removed from here (line 40). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
