jorisvandenbossche commented on PR #12837: URL: https://github.com/apache/arrow/pull/12837#issuecomment-1186804839
I certainly agree that it is indeed not a typical pattern to put so much code in the init file (it also makes it more difficult to open the file by name in an editor ..). As Raúl asked above, we could also move all this code into `pyarrow/parquet/parquet.py` (or some other name). I think one small advantage of the `__init__.py` in this case is that it leaves the path of the functions the same (`pyarrow.parquet.read_table`, instead of `pyarrow.parquet.parquet.read_table`), and whenever the actual path is not the public path, you will always get users that will start using full non-public path. But don't know if that's enough to say "practicality beats purity" in this case :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
