thisisnic commented on code in PR #12826:
URL: https://github.com/apache/arrow/pull/12826#discussion_r923235545
##########
r/src/compute-exec.cpp:
##########
@@ -146,20 +146,12 @@ std::shared_ptr<compute::ExecNode> ExecNode_Scan(
options->dataset_schema = dataset->schema();
- // ScanNode needs the filter to do predicate pushdown and skip partitions
- options->filter = ValueOrStop(filter->Bind(*dataset->schema()));
-
// ScanNode needs to know which fields to materialize (and which are
unnecessary)
std::vector<compute::Expression> exprs;
for (const auto& name : materialized_field_names) {
exprs.push_back(compute::field_ref(name));
}
- options->projection =
- ValueOrStop(call("make_struct", std::move(exprs),
-
compute::MakeStructOptions{std::move(materialized_field_names)})
- .Bind(*dataset->schema()));
Review Comment:
Thanks, appears to, yeah!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
