nealrichardson commented on code in PR #13622:
URL: https://github.com/apache/arrow/pull/13622#discussion_r923428064
##########
r/tools/winlibs.R:
##########
@@ -37,28 +37,32 @@ if
(!file.exists(sprintf("windows/arrow-%s/include/arrow/api.h", VERSION))) {
silent = quietly
)
}
+
# URL templates
nightly <- paste0(
getOption("arrow.dev_repo", "https://nightlies.apache.org/arrow/r";),
"/libarrow/bin/windows/arrow-%s.zip"
)
- rwinlib <- "https://github.com/rwinlib/arrow/archive/v%s.zip";
Review Comment:
Yeah I think we want to keep rwinlib as the first check, it makes sense for
us to stay plugged into that project even if it's not completely necessary
anymore.
##########
r/tools/nixlibs.R:
##########
@@ -22,7 +22,14 @@ dst_dir <- paste0("libarrow/arrow-", VERSION)
# TESTING is set in test-nixlibs.R; it won't be set when called from configure
test_mode <- exists("TESTING")
-arrow_repo <- paste0(getOption("arrow.dev_repo",
"https://nightlies.apache.org/arrow/r";), "/libarrow/")
+# Check if version string has 4th component
Review Comment:
There's one other case that we should support here. Suppose we submit 9.0.0
to CRAN and they reject it (as happens about 50% of the time). Assume the fix
is something in the R package only. We tweak that and resubmit as 9.0.0.1. We
want the official artifactory 9.0.0 libarrow to be used.
Here's some old code that did some inspection of the 4th component and did
different things:
https://github.com/apache/arrow/blob/6c7c4f0a09a3f40d65999511c77d0f21473b4de8/r/tools/nixlibs.R#L216-L233
We don't want exactly that, but maybe something that downloads from
artifactory if `is.na(p) || p < 100` or something like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
