lidavidm commented on code in PR #13567:
URL: https://github.com/apache/arrow/pull/13567#discussion_r923472704
##########
cpp/src/arrow/dataset/partition_test.cc:
##########
@@ -458,8 +458,10 @@ TEST_F(TestPartitioning, HivePartitioning) {
TEST_F(TestPartitioning, HivePartitioningEquals) {
const auto& array_vector = ArrayVector();
- const auto& other_vector = {ArrayFromJSON(utf8(), R"(["foo", "bar",
"baz"])"),
- ArrayFromJSON(utf8(), R"(["bar", "foo",
"baz"])")};
+ std::vector<std::shared_ptr<arrow::Array>> other_vector;
+ other_vector.reserve(2);
Review Comment:
nit, but for consistency with the surrounding code, this could just be
`ArrayVector other_vector(2)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
