kou commented on PR #13634: URL: https://github.com/apache/arrow/pull/13634#issuecomment-1188660384
The link error is occurred by our bundled OpenTelemetry C++ not `libarrow*.dylib`. It will be fixed by using OpenTelemetry C++ installed by Homebrew (but we need https://github.com/Homebrew/homebrew-core/pull/106115 ) ```diff diff --git a/cpp/Brewfile b/cpp/Brewfile index 9cffd8e3a8..8d709887e6 100644 --- a/cpp/Brewfile +++ b/cpp/Brewfile @@ -33,6 +33,7 @@ brew "lz4" brew "ninja" brew "numpy" brew "[email protected]" +brew "opentelemetry-cpp" brew "protobuf" brew "python" brew "rapidjson" ``` or building bundled OpenTelemetry C++ with `CMAKE_BUILD_TYPE=Release` ```diff diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake index 5d1da18b77..8c969cff94 100644 --- a/cpp/cmake_modules/ThirdpartyToolchain.cmake +++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake @@ -4387,10 +4387,16 @@ macro(build_opentelemetry) list(APPEND OPENTELEMETRY_LIBRARIES opentelemetry-cpp::${_OPENTELEMETRY_LIB}) endforeach() + if(PROTOBUF_VENDORED) + set(OPENTELEMETRY_CMAKE_BUILD_TYPE ${CMAKE_BUILD_TYPE}) + else() + set(OPENTELEMETRY_CMAKE_BUILD_TYPE Release) + endif() set(OPENTELEMETRY_CMAKE_ARGS ${EP_COMMON_TOOLCHAIN} "-DCMAKE_INSTALL_PREFIX=${OPENTELEMETRY_PREFIX}" - "-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}" + "-DCMAKE_BUILD_TYPE=${OPENTELEMETRY_CMAKE_BUILD_TYPE}" -DCMAKE_INSTALL_LIBDIR=lib "-DCMAKE_CXX_FLAGS=${EP_CXX_FLAGS}" -DBUILD_TESTING=OFF ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
