jorgecarleitao commented on a change in pull request #8102:
URL: https://github.com/apache/arrow/pull/8102#discussion_r490299782



##########
File path: rust/datafusion/tests/sql.rs
##########
@@ -609,6 +609,74 @@ fn execute(ctx: &mut ExecutionContext, sql: &str) -> 
Vec<String> {
     result_str(&results)
 }
 
+fn array_str(array: &Arc<dyn Array>, row_index: usize) -> String {
+    if array.is_null(row_index) {
+        return "NULL".to_string();
+    }

Review comment:
       @andygrove , isn't this the check that you refer to? I moved it to the 
begining of the function so that it applies to all types (array type or not). 
Note that this function is used to print any `ArrayRef`, in line 691. I.e. this 
function is not used only for Array-types. It is just written in a way that 
allows for recursion, on composite types.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to