dragosmg commented on code in PR #13627:
URL: https://github.com/apache/arrow/pull/13627#discussion_r924875872
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -571,11 +571,20 @@ register_bindings_datetime_parsers <- function() {
}
})
- ymd_parser_vec <- c("ymd", "ydm", "mdy", "myd", "dmy", "dym", "ym", "my",
"yq")
+ parser_vec <- c(
+ "ymd", "ydm", "mdy", "myd", "dmy", "dym", "ym", "my", "yq",
+ "ymd_HMS", "ymd_HM", "ymd_H", "dmy_HMS", "dmy_HM", "dmy_H",
+ "mdy_HMS", "mdy_HM", "mdy_H", "ydm_HMS", "ydm_HM", "ydm_H"
+ )
- ymd_parser_map_factory <- function(order) {
+ parser_map_factory <- function(order) {
force(order)
function(x, tz = NULL) {
Review Comment:
`lubridate::parse_date_time()` has a `truncated` argument (which we also
support with the `parse_date_time` binding). What do you think about exposing
it to the `ymd_...()` family of functions? The same goes for `quiet` where the
binding has a different default (is not chatty, `quiet = TRUE`).
I think I added support for these 2 arguments in `parse_date_time()` after
the first iteration of the `ymd_parser_map_factory()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
