viirya commented on code in PR #2094:
URL: https://github.com/apache/arrow-rs/pull/2094#discussion_r926031292
##########
arrow/src/datatypes/datatype.rs:
##########
@@ -195,6 +195,8 @@ pub enum DataType {
///
/// For example the number 123.45 has precision 5 and scale 2.
Decimal(usize, usize),
+ /// Exact decimal value with 256 bits width
+ Decimal256(usize, usize),
Review Comment:
I thought to add a parameter to current `Decimal` like you put above. But
soon I realize that I need to modify many places. And we need to do bit width
check there. As in C++ and Python implementations, they have Decimal128Type and
Decimal256Type separately. I feel that it is simple to work with.
And, yea, we need to rename `Decimal` to `Decimal128`. Although I've not
done it in this change as this is basically for Decimal256 interop test. I may
work on it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
