westonpace commented on code in PR #13651:
URL: https://github.com/apache/arrow/pull/13651#discussion_r926097680
##########
cpp/src/arrow/util/async_util.cc:
##########
@@ -105,15 +105,16 @@ Status AsyncTaskGroup::AddTask(const Future<>& task_fut) {
return AddTaskUnlocked(task_fut, std::move(guard));
}
-Status AsyncTaskGroup::AddTaskIfNotEnded(const Future<>& task_fut) {
+Result<bool> AsyncTaskGroup::AddTaskIfNotEnded(const Future<>& task_fut) {
Review Comment:
I went ahead and added this for consistency but the return bool here can
generally be ignored because the method doesn't actually start the work if it
returns false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
