paleolimbot commented on code in PR #13397:
URL: https://github.com/apache/arrow/pull/13397#discussion_r926785889
##########
r/R/query-engine.R:
##########
@@ -81,8 +82,8 @@ ExecPlan <- R6Class("ExecPlan",
# head and tail are not ExecNodes; at best we can handle them via
# SinkNode, so if there are any steps done after head/tail, we need
to
# evaluate the query up to then and then do a new query for the rest.
- # as_record_batch_reader() will build and run an ExecPlan
- node <- self$SourceNode(as_record_batch_reader(.data$.data))
+ # as_arrow_table() will build and run an ExecPlan
+ node <- self$SourceNode(as_arrow_table(.data$.data))
Review Comment:
@nealrichardson Did I do something horrible here? I *think* what this change
does is force the *result* of a `head()` into memory (suboptimal but probably
ok); however, I want to be very sure that I'm not forcing *source* of the
`head()` into memory here (which would be very very bad).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]