alamb commented on code in PR #2113:
URL: https://github.com/apache/arrow-rs/pull/2113#discussion_r927008045
##########
arrow/src/datatypes/datatype.rs:
##########
@@ -298,6 +299,49 @@ pub const MAX_DECIMAL_FOR_EACH_PRECISION: [i128; 38] = [
99999999999999999999999999999999999999,
];
+/// `MAX_DECIMAL_FOR_LARGER_PRECISION[p]` holds the maximum integer value
+/// that can be stored in [DataType::Decimal256] value of precision `p` > 38
Review Comment:
I took the liberty of merging this PR up from master.
##########
arrow/src/datatypes/datatype.rs:
##########
@@ -298,6 +299,49 @@ pub const MAX_DECIMAL_FOR_EACH_PRECISION: [i128; 38] = [
99999999999999999999999999999999999999,
];
+/// `MAX_DECIMAL_FOR_LARGER_PRECISION[p]` holds the maximum integer value
+/// that can be stored in [DataType::Decimal256] value of precision `p` > 38
Review Comment:
I took the liberty of merging the latest `apache/master` into this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
