save-buffer commented on code in PR #13669:
URL: https://github.com/apache/arrow/pull/13669#discussion_r927017388
##########
cpp/src/arrow/compute/exec/spilling_util.cc:
##########
@@ -0,0 +1,253 @@
+#include "spilling_util.h"
+
+namespace arrow
+{
+namespace compute
+{
+
+ struct ArrayInfo
+ {
+ int64_t num_children;
+ std::array<std::shared_ptr<Buffer>, 3> bufs;
+ std::array<size_t, 3> sizes;
+ bool has_dict;
+ };
+
+ struct SpillFile::BatchInfo
+ {
+ int64_t start;
+ std::vector<ArrayInfo> arrays;
+ };
+
+#ifdef _WIN32
+#include "windows_compatibility.h"
+
+const FileHandle kInvalidHandle = INVALID_HANDLE_VALUE;
+
+static Result<FileHandle> OpenTemporaryFile()
Review Comment:
Regarding forcing them to make a spilling directory, ideally I'd like
spilling to be completely transparent to them. If they do care, they can always
set the environment variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
