pitrou commented on code in PR #13661:
URL: https://github.com/apache/arrow/pull/13661#discussion_r927043219
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -597,25 +610,32 @@ endif()
# For CMAKE_BUILD_TYPE=FastDebug
# Same as DEBUG, except with some optimizations on.
# For CMAKE_BUILD_TYPE=Release
-# -O3: Enable all compiler optimizations
+# -O2: Enable all compiler optimizations
# Debug symbols are stripped for reduced binary size. Add
# -DARROW_CXXFLAGS="-g" to add them
+
if(NOT MSVC)
+ string(REPLACE "-O3" "" CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE}")
+
if(ARROW_GGDB_DEBUG)
set(ARROW_DEBUG_SYMBOL_TYPE "gdb")
set(C_FLAGS_DEBUG "-g${ARROW_DEBUG_SYMBOL_TYPE} -O0")
set(C_FLAGS_FASTDEBUG "-g${ARROW_DEBUG_SYMBOL_TYPE} -O1")
+ set(C_FLAGS_RELWITHDEBINFO "-g${ARROW_DEBUG_SYMBOL_TYPE} -O2")
set(CXX_FLAGS_DEBUG "-g${ARROW_DEBUG_SYMBOL_TYPE} -O0")
set(CXX_FLAGS_FASTDEBUG "-g${ARROW_DEBUG_SYMBOL_TYPE} -O1")
+ set(CXX_FLAGS_RELWITHDEBINFO "-g${ARROW_DEBUG_SYMBOL_TYPE} -O2")
else()
set(C_FLAGS_DEBUG "-g -O0")
set(C_FLAGS_FASTDEBUG "-g -O1")
+ set(C_FLAGS_RELWITHDEBINFO "-g -O2")
set(CXX_FLAGS_DEBUG "-g -O0")
set(CXX_FLAGS_FASTDEBUG "-g -O1")
+ set(CXX_FLAGS_RELWITHDEBINFO "-g -O2")
endif()
- set(C_FLAGS_RELEASE "-O3 -DNDEBUG")
- set(CXX_FLAGS_RELEASE "-O3 -DNDEBUG")
+ set(C_FLAGS_RELEASE "-O2 -DNDEBUG")
+ set(CXX_FLAGS_RELEASE "-O2 -DNDEBUG")
Review Comment:
Can you add `-DNDEBUG` to RelWithDebInfo as well?
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -383,6 +390,12 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -fno-semantic-interposition")
endif()
+ if("${CMAKE_BUILD_TYPE}" STREQUAL "RELEASE")
Review Comment:
What about relwithdebinfo?
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -597,25 +610,32 @@ endif()
# For CMAKE_BUILD_TYPE=FastDebug
# Same as DEBUG, except with some optimizations on.
# For CMAKE_BUILD_TYPE=Release
-# -O3: Enable all compiler optimizations
+# -O2: Enable all compiler optimizations
# Debug symbols are stripped for reduced binary size. Add
# -DARROW_CXXFLAGS="-g" to add them
+
if(NOT MSVC)
+ string(REPLACE "-O3" "" CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE}")
Review Comment:
RelWithDebInfo as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
