jhorstmann commented on a change in pull request #8204:
URL: https://github.com/apache/arrow/pull/8204#discussion_r490863732
##########
File path: rust/arrow/src/compute/kernels/boolean.rs
##########
@@ -123,9 +125,78 @@ pub fn not(left: &BooleanArray) -> Result<BooleanArray> {
Ok(BooleanArray::from(Arc::new(data)))
}
+pub fn is_null(input: &ArrayRef) -> Result<BooleanArray> {
+ if input.offset() % 8 != 0 {
Review comment:
This is currently a limitation of several kernels that operate on
boolean arrays or null bitmaps because we try to operate on whole bytes (or
larger) instead of individual bits for performance reasons. We would need a
nicer abstraction for those bit packed buffers to iterate over chunks,
regardless of offsets. I think it makes sense to look into such an
implementation together with @jorgecarleitao proposal for an iterator interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
