nealrichardson commented on code in PR #13541:
URL: https://github.com/apache/arrow/pull/13541#discussion_r927230552
##########
r/R/query-engine.R:
##########
@@ -191,7 +192,7 @@ ExecPlan <- R6Class("ExecPlan",
}
node
},
- Run = function(node) {
+ Run = function(node, explain = FALSE) {
Review Comment:
As I understand it, Acero is a push model, not pull. So when you call start
producing, it fires up, doesn't matter that you haven't pulled the first batch,
it's pushing batches to the reader. I also wouldn't assume that just because
the RBR object goes out of scope that that sends any signal to stop producing.
Assumptions aside, we should be able to observe this if we test with real data.
But I would think that printing the query shouldn't trigger any evaluation
on the data--anything >0 data being read is probably too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
