tustvold commented on PR #2127:
URL: https://github.com/apache/arrow-rs/pull/2127#issuecomment-1192834432
Sadly the benchmarks would suggest something is not quite happy with this
change...
```
cargo bench --bench builder -- --baseline master
Compiling arrow v18.0.0 (/data/raphael/arrow-rs/arrow)
Finished bench [optimized] target(s) in 49.08s
Running benches/builder.rs
(/data/raphael/arrow-rs/target/release/deps/builder-b12e265674091bcf)
WARNING: HTML report generation will become a non-default optional feature
in Criterion.rs 0.4.0.
This feature is being moved to cargo-criterion
(https://github.com/bheisler/cargo-criterion) and will be optional in a future
version of Criterion.rs. To silence this warning, either switch to
cargo-criterion or enable the 'html_reports' feature in your Cargo.toml.
WARNING: In Criterion.rs 0.4.0, running criterion benchmarks outside of
cargo-criterion will become a default optional feature.
The statistical analysis and reporting is being moved to cargo-criterion
(https://github.com/bheisler/cargo-criterion) and will be optional in a future
version of Criterion.rs. To silence this warning, either switch to
cargo-criterion or enable the 'cargo_bench_support' feature in your Cargo.toml.
Gnuplot not found, using plotters backend
bench_primitive/bench_primitive
time: [689.88 us 690.61 us 691.51 us]
thrpt: [5.6489 GiB/s 5.6562 GiB/s 5.6622 GiB/s]
change:
time: [-0.2259% -0.0747% +0.0924%] (p = 0.36 >
0.05)
thrpt: [-0.0923% +0.0748% +0.2264%]
No change in performance detected.
Benchmarking bench_primitive_nulls/bench_primitive_nulls: Warming up for
3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 9.9s, enable flat sampling, or reduce sample count to 50.
bench_primitive_nulls/bench_primitive_nulls
time: [1.9564 ms 1.9569 ms 1.9575 ms]
change: [+81.473% +81.584% +81.697%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
bench_bool/bench_bool time: [759.97 us 762.42 us 765.04 us]
thrpt: [653.56 MiB/s 655.80 MiB/s 657.92 MiB/s]
change:
time: [+111.83% +114.64% +117.24%] (p = 0.00 <
0.05)
thrpt: [-53.968% -53.411% -52.792%]
Performance has regressed.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild
bench_primitive/bench_string
time: [5.7475 ms 5.7512 ms 5.7550 ms]
thrpt: [1.1030 GiB/s 1.1037 GiB/s 1.1044 GiB/s]
change:
time: [+40.620% +40.811% +41.003%] (p = 0.00 <
0.05)
thrpt: [-29.079% -28.983% -28.886%]
Performance has regressed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
