rok commented on PR #13506: URL: https://github.com/apache/arrow/pull/13506#issuecomment-1192867698
> to clarify, that test would be nice to have, but it doesn't mean that without it the features aren't tested. ultimately, `parse_date_time()` calls `strptime` so, as long as those formats are tested with `strptime` they should work just fine with `parse_date_time()`. 👍 The thing is I started looking into frankenformats (e.g. `Y-%b-d`) which are supported by lubridate, but they brake our orders parsing here. I'll try to make it work and make it reject frankenformats if I can't. Does that seem ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
