Ted-Jiang commented on code in PR #2111:
URL: https://github.com/apache/arrow-rs/pull/2111#discussion_r928127548
##########
parquet/src/arrow/record_reader/definition_levels.rs:
##########
@@ -226,10 +226,27 @@ impl ColumnLevelDecoder for DefinitionLevelBufferDecoder {
impl DefinitionLevelDecoder for DefinitionLevelBufferDecoder {
fn skip_def_levels(
&mut self,
- _num_levels: usize,
- _max_def_level: i16,
+ num_levels: usize,
+ max_def_level: i16,
) -> Result<(usize, usize)> {
- Err(nyi_err!("https://github.com/apache/arrow-rs/issues/1792";))
+ // For now only support max_def_level == 1
+ if max_def_level == 1 {
Review Comment:
Got it
One question: if we preserve the bitmask if this is a nullable leaf
like
```
message Schema {
OPTIONAL GROUP group {
OPTIONAL int32 field;
}
}
```
we can not use the `PackedDecoder ` right ? because the value can be `1,2,3`
##########
parquet/src/arrow/record_reader/definition_levels.rs:
##########
@@ -226,10 +226,27 @@ impl ColumnLevelDecoder for DefinitionLevelBufferDecoder {
impl DefinitionLevelDecoder for DefinitionLevelBufferDecoder {
fn skip_def_levels(
&mut self,
- _num_levels: usize,
- _max_def_level: i16,
+ num_levels: usize,
+ max_def_level: i16,
) -> Result<(usize, usize)> {
- Err(nyi_err!("https://github.com/apache/arrow-rs/issues/1792";))
+ // For now only support max_def_level == 1
+ if max_def_level == 1 {
Review Comment:
Got it
One question: if we preserve the bitmask if this is a nullable leaf
like
```
message Schema {
OPTIONAL GROUP group {
OPTIONAL int32 field;
}
}
```
we can not use the `PackedDecoder ` right ? because the value can be `0,1,2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
