josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-695122375


   > I am thinking about another way: can we simply save the value/validity 
buffer capacities? so we can further improve the performance by avoiding the if 
branch in getValueBufferValueCapacity and the if branch in capAtMaxInt
   
   Let me check again on this; I might be wrong about the performance 
differences and safety if we aggressively cache; it was something I gave less 
thought to because of our specific use case 
(`arrow.enable_unsafe_memory_access=false`), but it might be more beneficial to 
do in general.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to