kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r491309216
##########
File path: cpp/src/arrow/python/python_to_arrow.cc
##########
@@ -1352,64 +927,40 @@ Status ConvertToSequenceAndInferSize(PyObject* obj,
PyObject** seq, int64_t* siz
return Status::OK();
}
-Status ConvertPySequence(PyObject* sequence_source, PyObject* mask,
- const PyConversionOptions& options,
- std::shared_ptr<ChunkedArray>* out) {
+Result<std::shared_ptr<ChunkedArray>> ConvertPySequence(PyObject* obj,
PyObject* mask,
+ const
PyConversionOptions& opts,
+ MemoryPool* pool) {
PyAcquireGIL lock;
PyObject* seq;
OwnedRef tmp_seq_nanny;
-
- std::shared_ptr<DataType> real_type;
+ PyConversionOptions options = opts; // copy options struct since we modify
it below
Review comment:
Right, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
