HaoYang670 commented on PR #2127: URL: https://github.com/apache/arrow-rs/pull/2127#issuecomment-1193875080
@jhorstmann from the [benchmark result](https://github.com/apache/arrow-rs/pull/2073), We didn't see `Option` introduce **obvious** overhead in the `no-null` case. (And we could trust `rustc` could optimize pattern-matching as fast (or even faster) as if-else branch, right?) What blocks this PR so far is that `bench_bool` gives different behaviour from `bench_primitive` (https://github.com/apache/arrow-rs/pull/2127#issuecomment-1193121747). And the performance regression is introduced by the `value builder` (which is not modified in the PR), but not the null buffer builder. (https://github.com/apache/arrow-rs/pull/2127#issuecomment-1193121071) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
