nevi-me commented on pull request #8223:
URL: https://github.com/apache/arrow/pull/8223#issuecomment-695347849


   @jhorstmann @paddyhoran this is related to the alignment fixes made 
recently. I noticed while reviewing another PR that we had a limitation on 
boolean kernels if offsets weren't a multiple of 8. So I've implemented a slice 
on `Buffer` that copies the buffer and removes the offsets.
   
   I expect there to be a minor perf impact, and I only use the above slice 
method when necessary.
   
   It's very likely that my implementation can be improved upon, but I'm at my 
current limits on bit manipulation. Please see https://godbolt.org/z/bMc5qd for 
some of the assembly generated. Not happy with the instruction count, and would 
appreciate some guidance or improvements. Feel free to push any changes 
directly on this branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to