tustvold commented on code in PR #2155:
URL: https://github.com/apache/arrow-rs/pull/2155#discussion_r929007257
##########
parquet/src/arrow/async_reader.rs:
##########
@@ -589,11 +599,87 @@ impl PageReader for InMemoryColumnChunkReader {
}
fn peek_next_page(&mut self) -> Result<Option<PageMetadata>> {
- Err(nyi_err!("https://github.com/apache/arrow-rs/issues/1792";))
+ while self.seen_num_values < self.chunk.num_values {
+ return if let Some(buffered_header) =
self.next_page_header.as_ref() {
+ match buffered_header.type_ {
Review Comment:
Perhaps we could extract this conversion into a From implementation? This
would reduce code duplication in this function and potentially elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
