thinkharderdev commented on code in PR #93:
URL: https://github.com/apache/arrow-ballista/pull/93#discussion_r929079457
##########
ballista/rust/scheduler/src/main.rs:
##########
@@ -100,10 +102,15 @@ async fn start_server(
let scheduler_grpc_server =
SchedulerGrpcServer::new(scheduler_server.clone());
+ let flight_sql_server =
FlightServiceServer::new(FlightSqlServiceImpl::new(
+ scheduler_server.clone(),
Review Comment:
Yeah, this probably needs to be cleaned up. The other places where we are
cloning the scheduler server can probably be refactored to just take an
`Arc<SchedulerState<>>`. Cloning the `EventLoop` might be more problematic
though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
