viirya commented on code in PR #2160:
URL: https://github.com/apache/arrow-rs/pull/2160#discussion_r929248360
##########
parquet/src/arrow/schema.rs:
##########
@@ -531,6 +531,32 @@ mod tests {
assert_eq!(&arrow_fields, converted_arrow_schema.fields());
}
+ #[test]
+ fn test_decimal_fields() {
+ let message_type = "
+ message test_schema {
+ REQUIRED INT32 decimal1 (DECIMAL(4,2));
+ REQUIRED INT64 decimal2 (DECIMAL(12,2));
+ REQUIRED FIXED_LEN_BYTE_ARRAY (16) decimal3
(DECIMAL(30,2));
+ REQUIRED BYTE_ARRAY decimal4 (DECIMAL(33,2));
+ }
+ ";
+
+ let parquet_group_type = parse_message_type(message_type).unwrap();
+
+ let parquet_schema =
SchemaDescriptor::new(Arc::new(parquet_group_type));
+ let converted_arrow_schema =
+ parquet_to_arrow_schema(&parquet_schema, None).unwrap();
+
+ let arrow_fields = vec![
+ Field::new("decimal1", DataType::Decimal(4,2), false),
+ Field::new("decimal2", DataType::Decimal(12,2), false),
+ Field::new("decimal3", DataType::Decimal(30,2), false),
+ Field::new("decimal4", DataType::Decimal(33,2), false),
Review Comment:
Yea, this has previously failed as I just ran this test to confirm.
```
---- arrow::schema::tests::test_decimal_fields stdout ----
thread 'arrow::schema::tests::test_decimal_fields' panicked at 'called
`Result::unwrap()` on an `Err` value: ArrowError("Unable to convert parquet
BYTE_ARRAY logical type Some(Decimal { scale: 2, precision: 33 }) or converted
type DECIMAL")', parquet/src/arrow/schema.rs:1734:60
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
