westonpace commented on PR #13426: URL: https://github.com/apache/arrow/pull/13426#issuecomment-1194684978
This error from the Windows CI is probably legitimate: ``` unity_0_cxx.obj : error LNK2019: unresolved external symbol "class std::shared_ptr<class arrow::Table> __cdecl arrow::compute::MakeRandomTimeSeriesTable(struct arrow::compute::TableGenerationProperties const &)" (?MakeRandomTimeSeriesTable@compute@arrow@@YA?AV?$shared_ptr@VTable@arrow@@@std@@AEBUTableGenerationProperties@12@@Z) referenced in function "struct arrow::compute::TableStats __cdecl arrow::compute::MakeTable(struct arrow::compute::TableGenerationProperties const &)" (?MakeTable@compute@arrow@@YA?AUTableStats@12@AEBUTableGenerationProperties@12@@Z) [D:\a\arrow\arrow\build\cpp\src\arrow\compute\exec\arrow-compute-asof-join-benchmark.vcxproj] ``` To fix this add `ARROW_TESTING_EXPORT` to `TableGenerationProperties` and `MakeRandomTimeSeriesTable` (Windows requires you to specifically label which functions are "external" and can be called outside of a shared object. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
