tustvold commented on code in PR #2158:
URL: https://github.com/apache/arrow-rs/pull/2158#discussion_r930040710
##########
parquet/src/arrow/array_reader/byte_array.rs:
##########
@@ -120,6 +120,15 @@ impl<I: OffsetSizeTrait + ScalarValue> ArrayReader for
ByteArrayReader<I> {
}
fn skip_records(&mut self, num_records: usize) -> Result<usize> {
+ if self.record_reader.column_reader().is_none() {
Review Comment:
This now behaves differently from next_batch which will potentially read
from multiple column chunks for the same "batch". Can we extract this logic
into a free function, similar to read_records, that performs the same loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
