nealrichardson commented on code in PR #13700:
URL: https://github.com/apache/arrow/pull/13700#discussion_r930125712
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -430,6 +430,23 @@ class ARROW_EXPORT SelectKSinkNodeOptions : public
SinkNodeOptions {
SelectKOptions select_k_options;
};
+/// \brief Make a node which selects a range of rows passed through it
+///
+/// All batches pushed to this node will be accumulated, then selected, by the
given
Review Comment:
If I just want to select a range of rows, why accumulate all batches? In R
how we've implemented `head()` now is to kill the plan after we've collected
enough rows: https://github.com/apache/arrow/blob/master/r/R/query-engine.R#L241
##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -430,6 +430,23 @@ class ARROW_EXPORT SelectKSinkNodeOptions : public
SinkNodeOptions {
SelectKOptions select_k_options;
};
+/// \brief Make a node which selects a range of rows passed through it
+///
+/// All batches pushed to this node will be accumulated, then selected, by the
given
+/// fields. Then sorted batches will be forwarded to the generator in sorted
order and
Review Comment:
How is FetchAndSort different from TopK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
