crepererum commented on PR #2183: URL: https://github.com/apache/arrow-rs/pull/2183#issuecomment-1196496561
> I think this is fine, although I do wonder if we need some way to highlight that this is a relatively expensive computation... The "expensiveness" was more concerned regarding the usage. I think a user should judge how expensive Eq/Hash on complex/container-like data structures are. You can easily Eq/Hash `BTreeSet<BTreeMap<String, Vec<String>>>` but sure, it's expensive. Same goes for a `Schema`, esp. if you attach LOADS for metadata. However we could add a doc comment somewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
