AlenkaF commented on PR #13311: URL: https://github.com/apache/arrow/pull/13311#issuecomment-1196537673
The CI is green, the extended builds are also green (failures are expected, see https://github.com/apache/arrow/pull/13311#issuecomment-1196522125 and https://github.com/apache/arrow/pull/13311#pullrequestreview-1049009931) so this **PR is ready for the 10.0.0** version. _I would like to have the approval of @jorisvandenbossche and @pitrou before that._ The suggestions were all looked at and commented or implemented. There are couple of follow-up issues that are planned for the next release - all saved under the umbrella issue ARROW-17122: ARROW-17172: [C++][Python] test_cython_api fails on windows ARROW-17016: [C++][Python] Move Arrow Python C++ tests into Cython ARROW-17154: [C++] Change cmake project name from arrow_python to pyarrow_cpp ARROW-17017: [C++][Python] Enable automate re-build of Arrow Python ARROW-17160: [C++] Create a base directory for PyArrow CPP header files **A note about the PyArrow cpp tests** The tests are actually not run on any of the CI builds at the moment as none of the builds have GTest bundled. We could change the GTest source for one of the conda builds temporary, if we feel it is necessary. Otherwise the check can be done locally until the tests are moved to Cython with ARROW-17016 (in the release 10.0.0) Thank you all for the help and guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
