tustvold commented on code in PR #2201:
URL: https://github.com/apache/arrow-rs/pull/2201#discussion_r931474006
##########
parquet/src/file/page_index/index_reader.rs:
##########
@@ -35,7 +35,7 @@ pub fn read_columns_indexes<R: ChunkReader>(
let length = lengths.iter().sum::<usize>();
//read all need data into buffer
- let mut reader = reader.get_read(offset, reader.len() as usize)?;
+ let mut reader = reader.get_read(offset, length)?;
Review Comment:
These were actually bugs that were only working because the ChunkReader
implementation for File doesn't validate the end offset is actually within the
range of the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
