alamb commented on code in PR #2194:
URL: https://github.com/apache/arrow-rs/pull/2194#discussion_r932058241
##########
arrow/src/array/equal/boolean.rs:
##########
@@ -75,20 +77,14 @@ pub(super) fn boolean_equal(
} else {
// get a ref of the null buffer bytes, to use in testing for nullness
let lhs_null_bytes = lhs.null_buffer().as_ref().unwrap().as_slice();
- let rhs_null_bytes = rhs.null_buffer().as_ref().unwrap().as_slice();
let lhs_start = lhs.offset() + lhs_start;
let rhs_start = rhs.offset() + rhs_start;
- (0..len).all(|i| {
+ BitIndexIterator::new(lhs_null_bytes, lhs_start, len).all(|i| {
Review Comment:
Ah, I think I missed that this was checking `BooleanArray` (and hence this
`get_bit` is getting the __value__ as you say). 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
