andygrove commented on a change in pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#discussion_r492076215



##########
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##########
@@ -374,6 +380,18 @@ impl RecordBatchReader for GroupedHashAggregateIterator {
                         col,
                         accums
                     ),
+                    DataType::LargeList(_) => {
+                        let len = array.len();
+                        let list_array =
+                            
array.as_any().downcast_ref::<LargeListArray>().unwrap();

Review comment:
       nit: I'd prefer that we use `expect` rather than `unwrap` so we can add 
a meaningful message.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to