tustvold opened a new pull request, #2207:
URL: https://github.com/apache/arrow-rs/pull/2207
# Which issue does this PR close?
Closes #2174
Closes #2206
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
The LocalFileSystem relies on canonicalizing filesystem paths to a URL in
order to assign them a consistent key. This logic breaks down when encountering
symlinks, as not only can files have multiple paths, but these paths may be
outside the prefix of the LocalFileSystem itself. The simplest solution is to
just not support them
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Explicitly ignore any symlinks encountered, which also allows dropping the
walkdir dependency as we no longer need protection against filesystem loops
caused by soft links. Hard link loops are impossible to handle, with most OSes
preventing them.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
Symlinks will no longer be followed by LocalFileSystem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
