[GitHub] [arrow] eerhardt commented on a diff in pull request #13732: ARROW-17223: [C#] DecimalArray incorrectly appends values greater than Decimal.MaxValue / 2 and less than Decimal.MinValue / 2

Thu, 28 Jul 2022 08:04:24 -0700 


eerhardt commented on code in PR #13732:
URL: https://github.com/apache/arrow/pull/13732#discussion_r932352429


##########
csharp/src/Apache.Arrow/DecimalUtility.cs:
##########
@@ -83,7 +83,7 @@ internal static void GetBytes(decimal value, int precision, 
int scale, int byteW
             int[] decimalBits = decimal.GetBits(value);
             int decScale = (decimalBits[3] >> 16) & 0x7F;
 #if NETCOREAPP
-            Span<byte> bigIntBytes = stackalloc byte[12];
+            Span<byte> bigIntBytes = stackalloc byte[13];

Review Comment:
   ```suggestion
                   Span<byte> bigIntBytes = stackalloc byte[13];
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to