viirya commented on code in PR #2211: URL: https://github.com/apache/arrow-rs/pull/2211#discussion_r932572658
########## arrow-flight/src/sql/server.rs: ########## @@ -47,6 +47,16 @@ pub trait FlightSqlService: /// When impl FlightSqlService, you can always set FlightService to Self type FlightService: FlightService; + /// Accept authentication and return a token + /// <https://arrow.apache.org/docs/format/Flight.html#authentication> + async fn do_handshake( + &self, + request: Request<Streaming<HandshakeRequest>>, + ) -> Result< + Response<Pin<Box<dyn Stream<Item = Result<HandshakeResponse, Status>> + Send>>>, + Status, + >; Review Comment: Yea, as you see, you can "override" default implementation in a trait nowadays. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org