alamb commented on code in PR #2981:
URL: https://github.com/apache/arrow-datafusion/pull/2981#discussion_r932588084
##########
datafusion/sql/src/planner.rs:
##########
@@ -1819,15 +1819,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
right: Box::new(self.sql_expr_to_logical_expr(*right, schema,
ctes)?),
}),
-
- SQLExpr::UnaryOp { op, expr } => match (&op, expr.as_ref()) {
- // The AST for Exists does not support the NOT EXISTS case so
it gets
- // wrapped in a unary NOT
- // https://github.com/sqlparser-rs/sqlparser-rs/issues/472
Review Comment:
https://github.com/sqlparser-rs/sqlparser-rs/issues/472 is indeed fixed 🎉
(thanks @togami2864)
##########
datafusion/sql/src/planner.rs:
##########
@@ -2278,6 +2269,17 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let mut result_days: i64 = 0;
let mut result_millis: i64 = 0;
+ // Only handle string exprs for now
+ let value = match &value {
Review Comment:
I am not sure about this one -- now the arguments to `INTERVAL` can be an
arbitrary expression rather than just a `String` (after
https://github.com/sqlparser-rs/sqlparser-rs/pull/517)
cc @ovr any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
