alamb commented on code in PR #2212:
URL: https://github.com/apache/arrow-rs/pull/2212#discussion_r932598588
##########
.github/workflows/parquet.yml:
##########
@@ -91,12 +102,15 @@ jobs:
- name: Check compilation --all-targets
run: |
cargo check -p parquet --all-targets
- - name: Check compilation --no-default-features --all-targets
+ - name: Check compilation --all-targets --no-default-features
Review Comment:
I moved `--all-targets` to the first part the command line to make it easier
to verify that all the combinations were checked
##########
.github/workflows/parquet.yml:
##########
@@ -91,12 +102,15 @@ jobs:
- name: Check compilation --all-targets
run: |
cargo check -p parquet --all-targets
- - name: Check compilation --no-default-features --all-targets
+ - name: Check compilation --all-targets --no-default-features
+ run: |
+ cargo check -p parquet --all-targets --no-default-features
+ - name: Check compilation --all-targets --no-default-features
--features-arrow
run: |
- cargo check -p parquet --no-default-features --all-targets
- - name: Check compilation --no-default-features --features-arrow
--all-targets
+ cargo check -p parquet --all-targets --no-default-features
--features arrow
+ - name: Check compilation --all-targets --all-features
run: |
- cargo check -p parquet --no-default-features --features arrow
--all-targets
+ cargo check -p parquet --all-targets --all-features
Review Comment:
This is a the missing combination
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
