emkornfield commented on a change in pull request #8177:
URL: https://github.com/apache/arrow/pull/8177#discussion_r492160325
##########
File path: cpp/src/parquet/CMakeLists.txt
##########
@@ -202,6 +203,19 @@ set(PARQUET_SRCS
stream_writer.cc
types.cc)
+if(CXX_SUPPORTS_AVX2)
+ # AVX2 is used as a proxy for BMI2.
Review comment:
@pitrou I added a comment below about why I think the current config
should be OK (and why people should not copy the flags). At this point, I
believe the only place BMI2 is enabled is on level_conversion_bmi2.cc which at
this point should always be guarded by runtime dispatch that specifically
checks for BMI2. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
