tustvold commented on code in PR #2221:
URL: https://github.com/apache/arrow-rs/pull/2221#discussion_r933064602
##########
parquet/src/column/writer/encoder.rs:
##########
@@ -152,17 +198,12 @@ impl<T: DataType> ColumnValueEncoder for
ColumnValueEncoderImpl<T> {
)
})?;
- if self.statistics_enabled == EnabledStatistics::Page {
- if let Some((min, max)) = slice.min_max(&self.descr) {
- update_min(&self.descr, min, &mut self.min_value);
- update_max(&self.descr, max, &mut self.max_value);
- }
- }
+ self.write_slice(slice)
+ }
- match &mut self.dict_encoder {
- Some(encoder) => encoder.put(slice),
- _ => self.encoder.put(slice),
- }
+ fn write_gather(&mut self, values: &Self::Values, indices: &[usize]) ->
Result<()> {
+ let slice: Vec<_> = indices.iter().map(|idx|
values[*idx].clone()).collect();
Review Comment:
This is pushed down from get_numeric_array_slice in arrow writer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
